Jackie-Jiang commented on a change in pull request #3979: Track "freshness" timestamp across consuming segments URL: https://github.com/apache/incubator-pinot/pull/3979#discussion_r282193136
########## File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java ########## @@ -96,9 +97,9 @@ private final int _numKeyColumns; // default message metadata - private static final StreamMessageMetadata _defaultMetadata = new StreamMessageMetadata(); - private long _lastIndexedTimestamp = Long.MIN_VALUE; - private long _latestIngestionTimestamp = Long.MIN_VALUE; + private static final StreamMessageMetadata _defaultMetadata = new StreamMessageMetadata(System.currentTimeMillis()); + private volatile long _lastIndexedTimestamp = Long.MIN_VALUE; + private volatile long _latestIngestionTimestamp = Long.MIN_VALUE; Review comment: (Optional) **_lastIndexedTimeMs** and **_latestIngestionTimeMs** to be more clear? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
