Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL
enhancement - phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285258179
##########
File path: pinot-common/src/thrift/request.thrift
##########
@@ -152,6 +153,7 @@ struct BrokerRequest {
14: optional map<string, string> queryOptions;
15: optional HavingFilterQuery havingFilterQuery;
16: optional HavingFilterQueryMap havingFilterSubQueryMap;
+ 17: optional query.PinotQuery pinotQuery;
Review comment:
Why do we put pinotQuery into BrokerRequest? All the info should be in
BrokerRequest right? This will double the size of the serialized bytes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
