This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new aed4b56 Minor fix for star-tree creation logs (#4215)
aed4b56 is described below
commit aed4b56f8caf16dbf43acadedf0e75b9109e903f
Author: Xiaotian (Jackie) Jiang <[email protected]>
AuthorDate: Fri May 17 14:26:18 2019 -0700
Minor fix for star-tree creation logs (#4215)
---
.../pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java | 11 ++++++-----
.../pinot/core/startree/v2/builder/MultipleTreesBuilder.java | 5 ++---
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java
b/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java
index 13f0ed8..596f550 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/BaseSingleTreeBuilder.java
@@ -304,7 +304,7 @@ abstract class BaseSingleTreeBuilder implements
SingleTreeBuilder {
public void build()
throws Exception {
long startTime = System.currentTimeMillis();
- LOGGER.info("Start building star-trees with config: {}", _builderConfig);
+ LOGGER.info("Starting building star-tree with config: {}", _builderConfig);
int numSegmentRecords = _segment.getSegmentMetadata().getTotalRawDocs();
Iterator<Record> recordIterator =
sortAndAggregateSegmentRecords(numSegmentRecords);
@@ -314,20 +314,21 @@ abstract class BaseSingleTreeBuilder implements
SingleTreeBuilder {
int numStarTreeRecords = _numDocs;
LOGGER.info("Generated {} star-tree records from {} segment records",
numStarTreeRecords, numSegmentRecords);
- int numRecordsUnderStarNode = _numDocs - numStarTreeRecords;
constructStarTree(_rootNode, 0, _numDocs);
- LOGGER.info("Finish constructing star-tree, got {} tree nodes and {}
records under star-node", _numNodes,
+ int numRecordsUnderStarNode = _numDocs - numStarTreeRecords;
+ LOGGER.info("Finished constructing star-tree, got {} tree nodes and {}
records under star-node", _numNodes,
numRecordsUnderStarNode);
createAggregatedDocs(_rootNode);
- LOGGER.info("Finish creating aggregated documents, got {} aggregated
records", _numDocs - numRecordsUnderStarNode);
+ int numAggregatedRecords = _numDocs - numSegmentRecords -
numRecordsUnderStarNode;
+ LOGGER.info("Finished creating aggregated documents, got {} aggregated
records", numAggregatedRecords);
createForwardIndexes();
StarTreeBuilderUtils
.serializeTree(new File(_outputDir, STAR_TREE_INDEX_FILE_NAME),
_rootNode, _dimensionsSplitOrder, _numNodes);
writeMetadata();
- LOGGER.info("Finish building star-tree in {}ms",
System.currentTimeMillis() - startTime);
+ LOGGER.info("Finished building star-tree in {}ms",
System.currentTimeMillis() - startTime);
}
private void appendToStarTree(Record record)
diff --git
a/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/MultipleTreesBuilder.java
b/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/MultipleTreesBuilder.java
index c875c97..ae96eac 100644
---
a/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/MultipleTreesBuilder.java
+++
b/pinot-core/src/main/java/org/apache/pinot/core/startree/v2/builder/MultipleTreesBuilder.java
@@ -70,7 +70,6 @@ public class MultipleTreesBuilder {
* @param builderConfigs List of builder configs
* @param indexDir Index directory
* @param buildMode Build mode (ON_HEAP or OFF_HEAP)
- * @throws Exception
*/
public MultipleTreesBuilder(List<StarTreeV2BuilderConfig> builderConfigs,
File indexDir, BuildMode buildMode)
throws Exception {
@@ -94,7 +93,7 @@ public class MultipleTreesBuilder {
throws Exception {
long startTime = System.currentTimeMillis();
int numStarTrees = _builderConfigs.size();
- LOGGER.info("Start building {} star-trees with configs: {} using {}
builder", numStarTrees, _builderConfigs,
+ LOGGER.info("Starting building {} star-trees with configs: {} using {}
builder", numStarTrees, _builderConfigs,
_buildMode);
try (
@@ -121,7 +120,7 @@ public class MultipleTreesBuilder {
FileUtils.forceDelete(starTreeIndexDir);
}
- LOGGER.info("Finish building {} star-trees in {}ms", numStarTrees,
System.currentTimeMillis() - startTime);
+ LOGGER.info("Finished building {} star-trees in {}ms", numStarTrees,
System.currentTimeMillis() - startTime);
}
private static SingleTreeBuilder
getSingleTreeBuilder(StarTreeV2BuilderConfig builderConfig, File outputDir,
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
