xiaohui-sun commented on a change in pull request #4217: [TE] distribute 
detection and notification tasks
URL: https://github.com/apache/incubator-pinot/pull/4217#discussion_r285312156
 
 

 ##########
 File path: 
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/CompositePipelineConfigTranslator.java
 ##########
 @@ -379,16 +380,24 @@ private void fillInDetectorWrapperProperties(Map<String, 
Object> properties, Map
     return properties;
   }
 
+  //  Default schedule:
+  //  minute granularity: every 15 minutes, starts at 0 minute
+  //  hourly: every hour, starts at 0 minute
+  //  daily: every day, starts at 2 pm UTC
+  //  others: every day, start at 12 am UTC
   private String buildCron() {
+    // starts at random second to reduce task spike
 
 Review comment:
   From database log all tasks are executed within the first three seconds 
which maps to the spike in mysql write spike since the task object is 
serialized in the database. We should distribute it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to