Jackie-Jiang commented on a change in pull request #4220: Adding a simple
partition function
URL: https://github.com/apache/incubator-pinot/pull/4220#discussion_r285316029
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/partition/PartitionFunctionFactory.java
##########
@@ -29,7 +29,7 @@
public class PartitionFunctionFactory {
// Enum for various partition functions to be added.
public enum PartitionFunctionType {
- Modulo, Murmur, ByteArray;
+ Modulo, Murmur, ByteArray, Simple;
Review comment:
Should we name it something more explicit, like HashCode?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]