Jackie-Jiang commented on a change in pull request #4229: Emit freshnessLag
metric from broker for queries hitting consuming segments
URL: https://github.com/apache/incubator-pinot/pull/4229#discussion_r286276194
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -308,12 +308,14 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
if (_queryLogRateLimiter.tryAcquire() || forceLog(brokerResponse,
totalTimeMs)) {
// Table name might have been changed (with suffix _OFFLINE/_REALTIME
appended)
LOGGER.info(
- "RequestId:{}, table:{}, timeMs:{}, docs:{}/{}, entries:{}/{},
segments(queried/processed/matched):{}/{}/{} "
- + "servers:{}/{}, groupLimitReached:{}, exceptions:{},
serverStats:{}, query:{}", requestId,
+ "RequestId:{}, table:{}, timeMs:{}, docs:{}/{}, entries:{}/{},
segments(queried/processed/matched/consuming):{}/{}/{}/{},"
Review comment:
Re-format into 2 lines maybe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
