jitendratheta edited a comment on issue #4243: Add support for passing headers in pinot client URL: https://github.com/apache/incubator-pinot/pull/4243#issuecomment-496656697 > Since this is not common to pass additional headers from the client, keep the existing methods and just add the new method that accepts header map. The idea here was to keep the interface level changes minimum. Thought of doing this also. It ran in more code changes with two exposed function in PinotClientTransportFactory.java and its implementation in concrete classes. Following the same type of separation for class JsonAsyncHttpPinotClientTransport, it also needs to have two constructors. With this in mind, I felt the current approach of having a single function and passing headers as null if not present makes a better fit here. At class ConnectionFactory entry point level, there is extra function two pass headers. Older ones are kept as it is for backward compatibility. Any thoughts are welcomed :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
