jackjlli commented on a change in pull request #4235: Add config to disable HLC
realtime segment completion
URL: https://github.com/apache/incubator-pinot/pull/4235#discussion_r288329472
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -273,8 +273,14 @@ private void setUpPinotController() {
new SegmentCompletionManager(helixParticipantManager,
_pinotLLCRealtimeSegmentManager, _controllerMetrics,
_controllerLeadershipManager,
_config.getSegmentCommitTimeoutSeconds());
- _realtimeSegmentsManager = new
PinotRealtimeSegmentManager(_helixResourceManager,
_controllerLeadershipManager);
- _realtimeSegmentsManager.start(_controllerMetrics);
+ if (_config.getHLCTablesAllowed()) {
+ LOGGER.info("HLC table is allowed. HLC realtime segment completion is
enabled.");
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
