snleee commented on issue #4252: pinot_kafka_0.9.0.1 module URL: https://github.com/apache/incubator-pinot/pull/4252#issuecomment-496746913 > > What is the plan on the naming for the module for different Kafka version implementation? I think that we should keep one implementation for each major version (e.g. `0.9.x`, `1.0.x`,`2.0.x`...) instead of having each module for each specific Kafka version. > > In principle yes, but are there guarantees that kafka does not change the api within these smaller releases? I am not sure. I would still prefer to keep one package per major version. If we need to bump up the minor version and kafka is not backward compatible, we can change our code to use new api. I don't like the approach of creating module for each version. For example, let's say that we want to bump up the version from 2.1.1 to 2.1.2 and they are backward compatible (or not). Are we going to create another module for `2.1.2` and copy more or less the same code? or are we going to change the package module name?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
