akshayrai commented on a change in pull request #4250: SoC - Separate out
Tuning from Translator
URL: https://github.com/apache/incubator-pinot/pull/4250#discussion_r288775147
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/rootcause/impl/MetricEntity.java
##########
@@ -102,4 +104,15 @@ public static MetricEntity fromURN(String urn) {
public static MetricEntity fromSlice(MetricSlice slice, double score) {
return fromMetric(score, slice.getMetricId(), slice.getFilters());
}
+
+ public static String buildMetricUrn(Map<String, Collection<String>>
filterMaps, long metricId) {
Review comment:
I think it makes sense to keep it here. I have updated the method to return
a `MetricEntity` and renamed the method to `fromMetric` to be consistent with
the other methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
