mcvsubbu commented on issue #4230: NULL value support for all data types URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-497154254 consuming segments will need a mutable presence vector. While committing the segment to persistent store, the presence vector should also be translated. This is where I thought the isNullable option will be used. If the user sets isNullable, then we use presense vector. Otherwise we use default value in the fwd index (or dictionary as the case may be). Perhaps call it handleNullValues instead of isNullable. The field is nullable always, just that whether we treat it as null or as default value is the question. Default value for metric is 0. Metric can very likely have a value of 0, so translating 0 to null value (i.e. building the presence vector on the server while loading) is not an option, I would think.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
