jitendratheta commented on a change in pull request #4243: Add support for
passing headers in pinot client
URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288864053
##########
File path:
pinot-api/src/main/java/org/apache/pinot/client/PinotClientTransportFactory.java
##########
@@ -18,9 +18,11 @@
*/
package org.apache.pinot.client;
+import java.util.Map;
+
/**
* Factory for client transports.
*/
interface PinotClientTransportFactory {
- PinotClientTransport buildTransport();
+ PinotClientTransport buildTransport(Map<String, String> headers);
Review comment:
@sunithabeeram as per your recommendation I made this interface as
public:stable.
This interface is not exposed as a public interface
1. should we make it `public interface PinotClientTransportFactory`?
2. If we do so, PinotClientTransportFactory is not accepted as an argument
by any class. ConnectionFactory class is using it by implicit object creation
inside the class. then does it make sense to have it public? or should we also
make `PinotClientTransport` as public and one of the argument to be passed to
function `ConnectionFactory.fromHostList` and let the caller decide the
implementation of it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
