jenniferdai commented on a change in pull request #4244: Add support for custom
record-readers in the create-segment tool
URL: https://github.com/apache/incubator-pinot/pull/4244#discussion_r289531542
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java
##########
@@ -291,7 +293,10 @@ public boolean execute()
File[] files = dir.listFiles(new FilenameFilter() {
@Override
public boolean accept(File dir, String name) {
- return name.toLowerCase().endsWith(_format.toString().toLowerCase());
+ if (_format != null) {
Review comment:
do we want to validate the record reader class, eg: try to instantiate it
and make sure it's valid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
