snleee commented on a change in pull request #4252: pinot_kafka_0.9.0.1 module
URL: https://github.com/apache/incubator-pinot/pull/4252#discussion_r289578399
##########
File path: pom.xml
##########
@@ -55,6 +55,7 @@
<module>pinot-azure-filesystem</module>
<module>pinot-orc</module>
<module>pinot-parquet</module>
+ <module>pinot-connectors</module>
Review comment:
@npawar Does that mean that we can pass `kafka.version` as a property to mvn
compilation command and pick default one (0.9 in our case) when it's not given?
If that's the case, it looks good to me 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
