jackjlli commented on a change in pull request #4047: Create
leadControllerResource in helix cluster
URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r290052797
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -37,8 +37,15 @@
public static final String SERVER_INSTANCE_TYPE = "server";
public static final String BROKER_INSTANCE_TYPE = "broker";
+ public static final String CONTROLLER_INSTANCE_TYPE = "controller";
public static final String BROKER_RESOURCE_INSTANCE = "brokerResource";
+ public static final String LEAD_CONTROLLER_RESOURCE_NAME =
"leadControllerResource";
+
+ // More information on why these numbers are set can be found in the
following doc:
+ //
https://cwiki.apache.org/confluence/display/PINOT/Controller+Separation+between+Helix+and+Pinot
+ public static final int
DEFAULT_NUMBER_OF_PARTITIONS_IN_LEAD_CONTROLLER_RESOURCE = 17;
Review comment:
A test `testLeadControllerAssignment` was added in PR to verify that the
difference of the number of masters for all controllers is at most 1. And it
shouldn't be that bad to have 1 more/ 1 less partition assignment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
