snleee commented on a change in pull request #4269: Add interface and implementations for the new segment assignment URL: https://github.com/apache/incubator-pinot/pull/4269#discussion_r290086294
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/InstancePartitions.java ########## @@ -0,0 +1,95 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.helix.core.assignment; + +import java.util.List; +import java.util.Map; +import java.util.TreeMap; +import org.apache.helix.ZNRecord; + + +/** + * Instance (server) partitions for the table. + * + * <p>The instance partitions are stored as a map from partition of the format: {@code <partitionId>_<replicaId>} to + * list of server instances. + */ +public class InstancePartitions { + private static final char SPLITTER = '_'; + + private final String _tableNameWithType; + private final Map<String, List<String>> _partitionToInstancesMap; + private int _numPartitions; + private int _numReplicas; Review comment: I guess that `numReplicas` for `InstancePartitions` is equivalent to `the number of groups in instance partition`. In that case, we may need to consider changing variable name for`numReplicas` to `numReplicaGroups`? In most cases, `numReplica` here is equal to `replication` factor; however, we use `numReplica=1` for supporting backward compatibility. In this case, `numReplica` and `replication` will mean different numbers. (`numReplica=1` while `replication can be 3`) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
