jenniferdai commented on a change in pull request #4253: Add segment pre-processing Hadoop job URL: https://github.com/apache/incubator-pinot/pull/4253#discussion_r290429800
########## File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/JobConfigConstants.java ########## @@ -52,4 +52,17 @@ // The path to the record reader to be configured public static final String RECORD_READER_PATH = "record.reader.path"; + + public static final String ENABLE_PARTITIONING = "enable.partitioning"; + public static final String ENABLE_SORTING = "enable.sorting"; + public static final String ENABLE_RESIZING = "enable.resizing"; + + public static final String PARTITION_COLUMN = "partition.column"; + public static final String NUMBER_OF_PARTITIONS = "number.partitions"; + public static final String PARTITION_FUNCTION = "partition.function"; + + public static final String SORTED_COLUMN = "sorted.column"; + + public static final String MINIMUM_NUMBER_OF_OUTPUT_FILES = "minimum.number.output.files"; Review comment: maybe min.num.output.files? and max.num.records below to shorten parameters ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
