npawar commented on a change in pull request #4287: Adding dataset metadata and its utility class URL: https://github.com/apache/incubator-pinot/pull/4287#discussion_r291771130
########## File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/dataset/DatasetMetadata.java ########## @@ -0,0 +1,106 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.metadata.dataset; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import javax.annotation.Nonnull; +import org.apache.helix.ZNRecord; + + +/** + * Dataset metadata. + * + * Note: Dataset metadata contains the internal metadata on dataset while dataset config will contain user's + * configuration on dataset. + * + * + * Dataset metadata is persisted under the ZK path: + * {@code <cluster>/PROPERTYSTORE/CONFIG/DATASET_METADATA/{datasetNameWithType}} + * + */ +public class DatasetMetadata { + private static final String TABLE_NAMES_KEY = "tableNames"; + + String _datasetNameWithType; + + // A list of tables that are associated to this dataset. + List<String> _tableNamesWithType; + + public DatasetMetadata(@Nonnull String datasetNameWithType) { + _datasetNameWithType = datasetNameWithType; + _tableNamesWithType = new ArrayList<>(); + } + + public DatasetMetadata(@Nonnull String datasetNameWithType, @Nonnull List<String> datasetToTablesMapping) { + _datasetNameWithType = datasetNameWithType; + _tableNamesWithType = datasetToTablesMapping; + } + + public String getDatasetNameWithType() { + return _datasetNameWithType; + } + + public List<String> getTableNamesWithType() { + return _tableNamesWithType; + } + + public void addTableName(String tableNameWithType) { + if (!_tableNamesWithType.contains(tableNameWithType)) { Review comment: tableNamesWithType.putIfAbsent(tableNameWithType) ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
