sunithabeeram commented on a change in pull request #4244: Add support for
custom record-readers in the create-segment tool
URL: https://github.com/apache/incubator-pinot/pull/4244#discussion_r291807247
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/CreateSegmentCommand.java
##########
@@ -228,15 +228,17 @@ public boolean execute()
}
}
- FileFormat configFormat = segmentGeneratorConfig.getFormat();
- if (_format == null) {
- if (configFormat == null) {
- throw new RuntimeException("Format cannot be null in config file.");
- }
- _format = configFormat;
- } else {
- if (configFormat != _format && configFormat != FileFormat.AVRO) {
- LOGGER.warn("Find format conflict in command line and config file, use
config in command line: {}", _format);
+ if (segmentGeneratorConfig.getRecordReaderPath() == null) {
Review comment:
Let me check the other path and keep them consistent if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
