snleee commented on a change in pull request #4288: Cleaning up getTableName()
for segment zk metadata
URL: https://github.com/apache/incubator-pinot/pull/4288#discussion_r292114175
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java
##########
@@ -258,7 +258,7 @@ public void run() {
// lets convert the segment now
RealtimeSegmentConverter converter =
new RealtimeSegmentConverter(realtimeSegment,
tempSegmentFolder.getAbsolutePath(), schema,
- realtimeSegmentZKMetadata.getTableName(), timeColumnName,
realtimeSegmentZKMetadata.getSegmentName(),
+ tableName, timeColumnName,
realtimeSegmentZKMetadata.getSegmentName(),
Review comment:
Both `LLRealtimeSegmentDataManager` and `HLRealtimeSegmentDataManager`
historically use `tableName`. I can update this to `tableNameWithType` or
`rawTableName` after checking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
