snleee commented on a change in pull request #4289: Cleaning up getTableName()
for segment metadata
URL: https://github.com/apache/incubator-pinot/pull/4289#discussion_r292223047
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadRestletResource.java
##########
@@ -303,35 +303,37 @@ private SuccessResponse uploadSegment(FormDataMultiPart
multiPart, boolean enabl
throw new UnsupportedOperationException("Unsupported upload type: "
+ uploadType);
}
+ String rawTableName = segmentMetadata.getTableName();
Review comment:
All other temporary variables in the same code block is not using `final`.
Do you think that we still need `final`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
