jihaozh commented on a change in pull request #4303: [TE] Clean up exceptions
in Yaml Resource
URL: https://github.com/apache/incubator-pinot/pull/4303#discussion_r292585637
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlResource.java
##########
@@ -98,6 +98,12 @@
protected static final Logger LOG =
LoggerFactory.getLogger(YamlResource.class);
private static ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+ private static final String PROP_DETECTION = "detection";
+ private static final String PROP_SUBSCRIPTION = "subscription";
+ private static final String PROP_PREVIEW = "preview";
+ private static final String PROP_CREATING = "creating";
Review comment:
How about making these operations as an enum? Seems not accurate to call
them "PROP_" because they are not yaml properties.
private enum Operation{
CREATING, UPDATING, ...
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
