Jackie-Jiang commented on a change in pull request #4216: PQL -> SQL
enhancement - phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r292690172
##########
File path:
pinot-common/src/main/java/org/apache/pinot/pql/parsers/pql2/ast/HavingAstNode.java
##########
@@ -31,4 +32,8 @@ public void updateBrokerRequest(BrokerRequest brokerRequest)
{
PredicateAstNode predicateAstNode = (PredicateAstNode)
getChildren().get(0);
RequestUtils.generateFilterFromTree(predicateAstNode.buildHavingQueryTree(),
brokerRequest);
}
+ @Override
+ public void updatePinotQuery(PinotQuery pinotQuery) {
+ // Skip HavingAstNode for now.
Review comment:
Maybe throw exception to avoid undefined behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
