mcvsubbu commented on a change in pull request #4306: Added tests for
RealtimeSegmentValidationManager
URL: https://github.com/apache/incubator-pinot/pull/4306#discussion_r292989384
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java
##########
@@ -635,6 +641,9 @@ public void
setOfflineSegmentIntervalCheckerInitialDelayInSeconds(long initialDe
}
public long getPeriodicTaskInitialDelayInSeconds() {
+ if
(containsKey(ControllerPeriodicTasksConf.SEGMENT_LEVEL_VALIDATION_INTERVAL_IN_SECONDS))
{
+ return
getLong(ControllerPeriodicTasksConf.SEGMENT_LEVEL_VALIDATION_INTERVAL_IN_SECONDS);
+ }
Review comment:
Disagree. We don't want users configuring this value, or provide a default
if they don't. We want to choose random delay all the time except for tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
