mcvsubbu commented on a change in pull request #4320: Add deprecated annotation
for segment & segment zk metadata
URL: https://github.com/apache/incubator-pinot/pull/4320#discussion_r294016017
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -360,6 +359,9 @@ public ServerType getServerType() {
public enum SegmentType {
OFFLINE, REALTIME
}
+
+ @Deprecated
+ public static final String TABLE_NAME = "segment.table.name";
Review comment:
In that case, this call should not be deprecated now. It can be deprecated
when we have the alternative way of determining table name (or, still kept in
there to validate). Not sure if header is the best way, or a query parameter,
or some sort of signed object that indicates the table name, and other data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
