snleee commented on a change in pull request #4320: Add deprecated annotation
for segment & segment zk metadata
URL: https://github.com/apache/incubator-pinot/pull/4320#discussion_r294021474
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -360,6 +359,9 @@ public ServerType getServerType() {
public enum SegmentType {
OFFLINE, REALTIME
}
+
+ @Deprecated
+ public static final String TABLE_NAME = "segment.table.name";
Review comment:
@mcvsubbu I double checked. `CommonConstants.Segment.TABLE_NAME` is used for
`segment zk metadata`. Segment metadata is using
`V1Constants.Segment.TABLE_NAME`. I reverted deprecate annotation for all
segment metadata related one and only added deprecated annotation for segment
zk metadata.
I accidentally ran commit ammend that the diff is gone :( Would you review
this once more?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
