haibow commented on issue #4225: Make Pinot schema evolution easier URL: https://github.com/apache/incubator-pinot/issues/4225#issuecomment-502889267 @Jackie-Jiang I tried the reload option 1. update schema for a table 2. reload all segments for the table (without restarting servers) 3. query the table again and see if the new field appears Seems it only works for OFFLINE table. For REALTIME table, segments are still loaded with old schema. Looking at code, seems schema is re-fetched for OFFLINE table only: ``` // For OFFLINE table, try to get schema for default columns if (TableNameBuilder.OFFLINE.tableHasTypeSuffix(tableNameWithType)) { schema = ZKMetadataProvider.getTableSchema(_propertyStore, tableNameWithType); } ``` https://github.com/apache/incubator-pinot/blob/master/pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java#L201-L204 Do you recall what was the reason/concern not to re-fetch schema for REALTIME tables?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
