jihaozh commented on a change in pull request #4333: [TE] Entity Yaml
(Composite Alert) Translator
URL: https://github.com/apache/incubator-pinot/pull/4333#discussion_r295412915
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/translator/DetectionConfigTranslator.java
##########
@@ -157,18 +157,25 @@
private static final String PROP_DESC_NAME = "description";
private static final String PROP_ACTIVE = "active";
+ private static final String PROP_ALERTS = "alerts";
+ private static final String COMPOSITE_ALERT = "COMPOSITE_ALERT";
+ private static final String METRIC_ALERT = "METRIC_ALERT";
+
+
private static final DetectionRegistry DETECTION_REGISTRY =
DetectionRegistry.getInstance();
static {
// do not tune for alerts migrated from legacy anomaly function.
DetectionRegistry.registerComponent("com.linkedin.thirdeye.detection.components.AdLibAlertFilter",
"MIGRATED_ALGORITHM_FILTER");
DetectionRegistry.registerComponent("com.linkedin.thirdeye.detection.components.AdLibAnomalyDetector",
"MIGRATED_ALGORITHM");
+ DetectionRegistry.registerComponent(MockGrouper.class.getName(),
"MOCK_GROUPER");
Review comment:
can we add an annotation in Mock Grouper then we don't need to register it
explicitly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
