Jackie-Jiang commented on a change in pull request #4335: Refresh schema when
reloading segments
URL: https://github.com/apache/incubator-pinot/pull/4335#discussion_r295581444
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixInstanceDataManager.java
##########
@@ -180,10 +180,8 @@ public void reloadSegment(@Nonnull String
tableNameWithType, @Nonnull String seg
Preconditions.checkNotNull(tableConfig);
Schema schema = null;
- // For OFFLINE table, try to get schema for default columns
- if (TableNameBuilder.OFFLINE.tableHasTypeSuffix(tableNameWithType)) {
- schema = ZKMetadataProvider.getTableSchema(_propertyStore,
tableNameWithType);
- }
+ // For REALTIME and OFFLINE tables, try to get schema for default columns
Review comment:
(nit) Can you combine 182-184 into one line? The comment seems redundant
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
