jackjlli commented on a change in pull request #4360: Adding util methods for
controller that will be used in offline push
URL: https://github.com/apache/incubator-pinot/pull/4360#discussion_r296911540
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -89,12 +91,14 @@ public static FileUploadType getDefaultUploadType() {
public static final int DEFAULT_SOCKET_TIMEOUT_MS = 600 * 1000; // 10 minutes
public static final int GET_REQUEST_SOCKET_TIMEOUT_MS = 5 * 1000; // 5
seconds
+ public static final int DELETE_REQUEST_SOCKET_TIMEOUT_MS = 10 * 1000; // 10
seconds
private static final String HTTP = "http";
private static final String HTTPS = "https";
private static final String SCHEMA_PATH = "/schemas";
private static final String OLD_SEGMENT_PATH = "/segments";
private static final String SEGMENT_PATH = "/v2/segments";
+ private static final String DELETE_SEGMENT_PATH = "/segments";
Review comment:
I think it's unnecessary, since you've already specify the behavior in the
method name `getDeleteSegmentHttpUri`. Not a good idea to add more and more
constants here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
