jihaozh commented on a change in pull request #4359: [TE] Tuning of Composite
alert - Store metric refs in component spec
URL: https://github.com/apache/incubator-pinot/pull/4359#discussion_r296949055
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/translator/DetectionConfigTranslator.java
##########
@@ -470,6 +471,9 @@ private void buildComponentSpec(Map<String, Object>
yamlConfig, String type, Str
String componentClassName = DETECTION_REGISTRY.lookup(type);
componentSpecs.put(PROP_CLASS_NAME, componentClassName);
+ componentSpecs.put(PROP_METRIC, MapUtils.getString(yamlConfig,
PROP_METRIC));
Review comment:
Where is this used? How about store the metric urn?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
