sunithabeeram commented on a change in pull request #4356: Emit metrics to
track performance against specific Service-Level-Objectives (SLO)
URL: https://github.com/apache/incubator-pinot/pull/4356#discussion_r297223971
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -361,6 +384,52 @@ private boolean forceLog(BrokerResponse brokerResponse,
long totalTimeMs) {
return false;
}
+
+ private void scoreResponse(BrokerResponse response, RequestStatistics stats)
{
+
+ try {
+
+ if (response == BrokerResponseNative.EMPTY_RESULT || response ==
BrokerResponseNative.NO_TABLE_RESULT
Review comment:
Non-existent table issue is caught earlier with the auth check, so I think
this should be OK. This can also happen when we have a valid table, but EV
doesn't reflect it. A signal on the second case seems important than a false
alarm on the first. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
