Jackie-Jiang commented on a change in pull request #4362: Optimize
MutableOffHeapByteArrayStore by directly calling the PinotDataBuffer API
URL: https://github.com/apache/incubator-pinot/pull/4362#discussion_r297418269
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/writer/impl/MutableOffHeapByteArrayStore.java
##########
@@ -157,7 +150,7 @@ public void close()
_pinotDataBuffer.close();
}
- private long getSize() {
+ private int getSize() {
Review comment:
The total size could be long, while each buffer's size is limited to 2G.
Besides, for real-time forward index/dictionary, I don't think we should
allow buffers of gigabytes because that will definitely cause problem when
committing the segment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
