mcvsubbu commented on a change in pull request #4367: CompletionConfig for
realtime tables
URL: https://github.com/apache/incubator-pinot/pull/4367#discussion_r297779134
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -320,6 +320,11 @@ public ServerType getServerType() {
IN_PROGRESS, DONE
}
+ public enum CompletionMode {
+ DEFAULT, // default behavior
+ DOWNLOAD // always download the segment
Review comment:
please add more document the behavior here,as verbose as you can (comments
are free :)). In the current implementation, we are planning on the server
paying attention to this config, and deciding to download or build a realtime
segment that it knows are equivalent either way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
