siddharthteotia edited a comment on issue #4368: 3891: Check for validity of segment start/end time during segment generation URL: https://github.com/apache/incubator-pinot/pull/4368#issuecomment-506498226 @jackjlli , for the tests that I have fixed and the ones that I added, test data was generated by the test code using java random. So it was okay to fix the failures by code change in test code. However, for the other set of tests, the data is not generated by test code itself. Instead, it is an external avro file and we use that to build a segment. So no code change seems possible to change the data. As discussed offline, I will explore using avro-tools and see if the time column data in avro file can be updated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
