kishoreg commented on a change in pull request #4387: Adding Calcite SQL Parser and make another entry point to query Pinot URL: https://github.com/apache/incubator-pinot/pull/4387#discussion_r299215708
########## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ########## @@ -0,0 +1,273 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.sql.parsers; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.regex.Matcher; +import java.util.regex.Pattern; +import org.apache.calcite.config.Lex; +import org.apache.calcite.sql.SqlBasicCall; +import org.apache.calcite.sql.SqlIdentifier; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlLiteral; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlNodeList; +import org.apache.calcite.sql.SqlNumericLiteral; +import org.apache.calcite.sql.SqlOrderBy; +import org.apache.calcite.sql.SqlSelect; +import org.apache.calcite.sql.parser.SqlParseException; +import org.apache.calcite.sql.parser.SqlParser; +import org.apache.pinot.common.request.DataSource; +import org.apache.pinot.common.request.Expression; +import org.apache.pinot.common.request.PinotQuery; +import org.apache.pinot.common.utils.request.RequestUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +public class CalciteSqlParser { + + private static final Logger LOGGER = LoggerFactory.getLogger(CalciteSqlParser.class); + + /** Lexical policy similar to MySQL with ANSI_QUOTES option enabled. (To be + * precise: MySQL on Windows; MySQL on Linux uses case-sensitive matching, + * like the Linux file system.) The case of identifiers is preserved whether + * or not they quoted; after which, identifiers are matched + * case-insensitively. Double quotes allow identifiers to contain + * non-alphanumeric characters. */ + private static Lex PINOT_LEX = Lex.MYSQL_ANSI; + + // To Keep the backward compatibility with 'OPTION' Functionality in PQL, which is used to + // provide more hints for query processing. + // + // PQL syntax is: `OPTION (<key> = <value>)` + // + // Multiple OPTIONs is also supported by: + // either + // `OPTION (<k1> = <v1>, <k2> = <v2>, <k3> = <v3>)` + // or + // `OPTION (<k1> = <v1>) OPTION (<k2> = <v2>) OPTION (<k3> = <v3>)` + private static final Pattern OPTIONS_REGEX_PATTEN = + Pattern.compile("option\\s*\\(([^\\)]+)\\)", Pattern.CASE_INSENSITIVE); + + public static PinotQuery compileToPinotQuery(String sql) Review comment: Why static methods? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
