buchireddy opened a new issue #4393: Cleanup FixedByteValueReaderWriter and ValueReader buffer usage URL: https://github.com/apache/incubator-pinot/issues/4393 FixedByteValueReaderWriter is only implementing the ValueReader.java interface but it is wrongly named as ReaderWriter. This needs to be cleaned up to avoid confusion and should be moved to appropriate package instead of keeping it in `org.apache.pinot.core.io.util` Also, the interface methods on ValueReader.java are taking buffer (for reusing the buffer) but that poses challenges in reusing buffer if the implementations aren't padding the values. Need to check further and remove buffer from its methods. Some discussion related to this can be found in the PR: https://github.com/apache/incubator-pinot/pull/4321 cc @mayankshriv @kishoreg
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
