buchireddy commented on a change in pull request #4321: #4317 Feature/variable
length bytes offline dictionary for indexing bytes and string dicts.
URL: https://github.com/apache/incubator-pinot/pull/4321#discussion_r300053298
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/converter/RealtimeSegmentConverter.java
##########
@@ -54,10 +54,12 @@
private List<String> invertedIndexColumns;
private List<String> noDictionaryColumns;
private StarTreeIndexSpec starTreeIndexSpec;
+ private List<String> varLengthDictionaryColumns;
public RealtimeSegmentConverter(MutableSegmentImpl realtimeSegment, String
outputPath, Schema schema,
String tableName, String timeColumnName, String segmentName, String
sortedColumn,
- List<String> invertedIndexColumns, List<String> noDictionaryColumns,
StarTreeIndexSpec starTreeIndexSpec) {
+ List<String> invertedIndexColumns, List<String> noDictionaryColumns,
+ List<String> varLengthDictionaryColumns, StarTreeIndexSpec
starTreeIndexSpec) {
Review comment:
I've not spent enough time on this part of code to give my take on what's
the best thing to do.
If one of you can please log an issue with more details, I'll take it up
next, check the code and can make the changes finally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
