Jackie-Jiang commented on a change in pull request #4399: Moving handling of
NULL values from RecordReaders to NullValueTransfo…
URL: https://github.com/apache/incubator-pinot/pull/4399#discussion_r301730026
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/JsonUtils.java
##########
@@ -137,13 +138,15 @@ public static Object extractValue(@Nullable JsonNode
jsonValue, FieldSpec fieldS
}
return values;
} else {
- return new Object[]{fieldSpec.getDefaultNullValue()};
+ return null;
Review comment:
IMO empty array should be a valid value for MV columns instead of treated as
null. We don't have that support now, but maybe better to add some comments or
TODOs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
