codecov-io commented on issue #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#issuecomment-510276514 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=h1) Report > Merging [#4418](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/07e2c721d964c290888c66bf7750e6b2067d4ca1?src=pr&el=desc) will **increase** coverage by `9.32%`. > The diff coverage is `59.45%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4418 +/- ## ============================================ + Coverage 55.72% 65.05% +9.32% Complexity 20 20 ============================================ Files 1068 1076 +8 Lines 55557 56173 +616 Branches 7910 8068 +158 ============================================ + Hits 30957 36541 +5584 + Misses 22202 17015 -5187 - Partials 2398 2617 +219 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ment/creator/impl/SegmentColumnarIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9TZWdtZW50Q29sdW1uYXJJbmRleENyZWF0b3IuamF2YQ==) | `87.1% <ø> (+0.36%)` | `0 <0> (ø)` | :arrow_down: | | [...dex/loader/invertedindex/InvertedIndexHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2luZGV4L2xvYWRlci9pbnZlcnRlZGluZGV4L0ludmVydGVkSW5kZXhIYW5kbGVyLmphdmE=) | `78.57% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...impl/fwd/SingleValueSortedForwardIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9md2QvU2luZ2xlVmFsdWVTb3J0ZWRGb3J3YXJkSW5kZXhDcmVhdG9yLmphdmE=) | `95% <100%> (+0.26%)` | `0 <0> (ø)` | :arrow_down: | | [...or/impl/inv/OffHeapBitmapInvertedIndexCreator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zZWdtZW50L2NyZWF0b3IvaW1wbC9pbnYvT2ZmSGVhcEJpdG1hcEludmVydGVkSW5kZXhDcmVhdG9yLmphdmE=) | `86.4% <100%> (+0.4%)` | `0 <0> (ø)` | :arrow_down: | | [.../main/java/org/apache/pinot/common/Closeables.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vQ2xvc2VhYmxlcy5qYXZh) | `36.36% <36.36%> (ø)` | `0 <0> (?)` | | | [...riter/impl/FixedByteSingleValueMultiColWriter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9pby93cml0ZXIvaW1wbC9GaXhlZEJ5dGVTaW5nbGVWYWx1ZU11bHRpQ29sV3JpdGVyLmphdmE=) | `83.33% <66.66%> (-1.78%)` | `0 <0> (ø)` | | | [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `63.83% <0%> (-20.86%)` | `0% <0%> (ø)` | | | [...pache/pinot/core/util/SortedRangeIntersection.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL1NvcnRlZFJhbmdlSW50ZXJzZWN0aW9uLmphdmE=) | `83.82% <0%> (-7.36%)` | `0% <0%> (ø)` | | | [.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jbGllbnQvQ29ubmVjdGlvbi5qYXZh) | `36.5% <0%> (-4.04%)` | `0% <0%> (ø)` | | | [...regation/function/customobject/QuantileDigest.java](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9jdXN0b21vYmplY3QvUXVhbnRpbGVEaWdlc3QuamF2YQ==) | `57.74% <0%> (-0.45%)` | `0% <0%> (ø)` | | | ... and [338 more](https://codecov.io/gh/apache/incubator-pinot/pull/4418/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=footer). Last update [07e2c72...14736b6](https://codecov.io/gh/apache/incubator-pinot/pull/4418?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
