siddharthteotia commented on a change in pull request #4418: Fix potential resource leak in the way we close a collection of closeables URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r302684714
########## File path: pinot-common/src/main/java/org/apache/pinot/common/Closeables.java ########## @@ -0,0 +1,61 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common; + +import java.io.Closeable; +import java.io.IOException; +import java.util.Arrays; + + +public class Closeables { + + public static void close(Iterable<? extends Closeable> ac) + throws IOException { + + if (ac == null) { + return; + } else if (ac instanceof Closeable) { + ((Closeable) ac).close(); + return; + } + + IOException topLevelException = null; + + for (Closeable closeable : ac) { + try { + if (closeable != null) { + closeable.close(); + } + } catch (IOException e) { + if (topLevelException == null) { + topLevelException = e; + } else if (e != topLevelException) { + topLevelException.addSuppressed(e); + } + } + } + + if (topLevelException != null) { + throw topLevelException; Review comment: The final exception that is logged by the logger shows the call stack of top level along with any of the suppressed exceptions. Also, I added a small change to log (including the name of closeable) as and when we catch an exception ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
