siddharthteotia commented on a change in pull request #4368: 3891: Check for
validity of segment start/end time during segment generation
URL: https://github.com/apache/incubator-pinot/pull/4368#discussion_r302770596
##########
File path:
pinot-core/src/test/java/org/apache/pinot/core/data/readers/PinotSegmentUtil.java
##########
@@ -47,16 +52,16 @@ private PinotSegmentUtil() {
public static List<GenericRow> createTestData(Schema schema, int numRows) {
List<GenericRow> rows = new ArrayList<>();
- final Random random = new Random();
+ final ThreadLocalRandom random = ThreadLocalRandom.current();
Review comment:
For this class, there is no other use except for the fact that
ThreadLocalRandom has the method nextLong(start, end) whereas java.util.Random
doesn't provide any such method to randomly generate long values between a
given lower and upper bound
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
