jackjlli commented on a change in pull request #4426: Add URIUtils class to
handle URI/URL encoding/decoding
URL: https://github.com/apache/incubator-pinot/pull/4426#discussion_r302788814
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadRestletResource.java
##########
@@ -185,13 +181,8 @@ public Response downloadSegment(
} catch (Exception e) {
throw new ControllerApplicationException(LOGGER, e.getMessage(),
Response.Status.INTERNAL_SERVER_ERROR, e);
}
- try {
- segmentName = URLDecoder.decode(segmentName, "UTF-8");
- } catch (UnsupportedEncodingException e) {
- String errStr = "Could not decode segment name '" + segmentName + "'";
- throw new ControllerApplicationException(LOGGER, errStr,
Response.Status.BAD_REQUEST);
- }
- final File dataFile = new File(provider.getBaseDataDir(),
StringUtil.join("/", tableName, segmentName));
+ segmentName = URIUtils.decode(segmentName);
+ File dataFile = new File(new File(provider.getBaseDataDir(), tableName),
segmentName);
Review comment:
Why not use `toFile()` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
