codecov-io commented on issue #4431: Misc fix for controller tests URL: https://github.com/apache/incubator-pinot/pull/4431#issuecomment-510863430 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4431?src=pr&el=h1) Report > Merging [#4431](https://codecov.io/gh/apache/incubator-pinot/pull/4431?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/aadcd36289c0da12f6f7e164928070a3ccb2d103?src=pr&el=desc) will **increase** coverage by `11.4%`. > The diff coverage is `57.69%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4431?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4431 +/- ## ============================================ + Coverage 44.37% 55.77% +11.4% - Complexity 0 20 +20 ============================================ Files 1075 1075 Lines 55837 55837 Branches 7965 7966 +1 ============================================ + Hits 24775 31144 +6369 + Misses 28939 22260 -6679 - Partials 2123 2433 +310 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4431?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ller/api/resources/PinotControllerHealthCheck.java](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90Q29udHJvbGxlckhlYWx0aENoZWNrLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...api/resources/PinotTableConfigRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90VGFibGVDb25maWdSZXN0bGV0UmVzb3VyY2UuamF2YQ==) | `0% <ø> (-24.36%)` | `0 <0> (ø)` | | | [...oller/api/resources/PinotTableRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90VGFibGVSZXN0bGV0UmVzb3VyY2UuamF2YQ==) | `45.23% <0%> (+11.58%)` | `0 <0> (ø)` | :arrow_down: | | [...not/controller/validation/StorageQuotaChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1N0b3JhZ2VRdW90YUNoZWNrZXIuamF2YQ==) | `70.93% <33.33%> (+45.04%)` | `0 <0> (ø)` | :arrow_down: | | [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `70.96% <66.66%> (+14.51%)` | `0 <0> (ø)` | :arrow_down: | | [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `58.68% <90%> (+17.96%)` | `0 <0> (ø)` | :arrow_down: | | [...e/pinot/core/operator/blocks/EmptyFilterBlock.java](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9ibG9ja3MvRW1wdHlGaWx0ZXJCbG9jay5qYXZh) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...ime/impl/kafka/KafkaSimpleConsumerFactoryImpl.java](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1jb25uZWN0b3Ita2Fma2EtMC45L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwva2Fma2EvS2Fma2FTaW1wbGVDb25zdW1lckZhY3RvcnlJbXBsLmphdmE=) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...ot/minion/events/EventObserverFactoryRegistry.java](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXZlbnRzL0V2ZW50T2JzZXJ2ZXJGYWN0b3J5UmVnaXN0cnkuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | [...minion/executor/ConvertToRawIndexTaskExecutor.java](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhlY3V0b3IvQ29udmVydFRvUmF3SW5kZXhUYXNrRXhlY3V0b3IuamF2YQ==) | `0% <0%> (-100%)` | `0% <0%> (ø)` | | | ... and [746 more](https://codecov.io/gh/apache/incubator-pinot/pull/4431/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4431?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4431?src=pr&el=footer). Last update [aadcd36...9c4d9fa](https://codecov.io/gh/apache/incubator-pinot/pull/4431?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
