npawar commented on a change in pull request #4397: Adding Support for Kafka 2.0 Consumer URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r303105976
########## File path: pinot-connectors/pinot-connector-kafka-2.0/src/main/java/org/apache/pinot/core/realtime/impl/kafka2/Kafka2PartitionLevelConnectionHandler.java ########## @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.realtime.impl.kafka2; + +import com.google.common.annotations.VisibleForTesting; +import java.io.IOException; +import java.util.Collections; +import java.util.Properties; +import org.apache.kafka.clients.consumer.Consumer; +import org.apache.kafka.clients.consumer.ConsumerConfig; +import org.apache.kafka.clients.consumer.KafkaConsumer; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.serialization.BytesDeserializer; +import org.apache.kafka.common.serialization.StringDeserializer; +import org.apache.kafka.common.utils.Bytes; +import org.apache.pinot.core.realtime.stream.StreamConfig; + + +public abstract class Kafka2PartitionLevelConnectionHandler { + + protected final Kafka2PartitionLevelStreamConfig _config; + protected final String _clientId; + protected final int _partition; + protected final String _topic; + protected final Consumer<String, Bytes> _consumer; + protected final TopicPartition _topicPartition; + + public Kafka2PartitionLevelConnectionHandler(String clientId, StreamConfig streamConfig, int partition) { Review comment: The StreamMetadataProvider also extends KafkaConnectionhandler. The StreamMetadataProvider can be created with or without partition number. The PartitionCountFetcher creates the StreamMetadataProvider without a partition number. The PartitionOffsetFetcher creates the StreamMetadataProvider with a partition number ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
