jackjlli commented on a change in pull request #4431: Misc fix for controller
tests
URL: https://github.com/apache/incubator-pinot/pull/4431#discussion_r303168018
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -1087,9 +1086,6 @@ public void addTable(@Nonnull TableConfig tableConfig)
// lets add table configs
ZKMetadataProvider.setOfflineTableConfig(_propertyStore,
tableNameWithType, tableConfig.toZNRecord());
-
_propertyStore.create(ZKMetadataProvider.constructPropertyStorePathForResource(tableNameWithType),
Review comment:
Why don't we need to write to property store when adding a table?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
