buchireddy commented on issue #4432: #4401 Reuse a ThreadLocal byte[] when reading String elements from the variable length value reader. URL: https://github.com/apache/incubator-pinot/pull/4432#issuecomment-511152643 @Jackie-Jiang I've done some testing using `StringDictionaryPerfTest.java` and captured the GC logs and parsed them using an online tool. Here are the stats and full reports. Before change: https://gceasy.io/my-gc-report.jsp?p=c2hhcmVkLzIwMTkvMDcvMTMvLS1nY193aXRob3V0X2NoYW5nZS5sb2ctLTItMTYtNTE=&channel=WEB With change: https://gceasy.io/my-gc-report.jsp?p=c2hhcmVkLzIwMTkvMDcvMTMvLS1nY193aXRoX2NoYW5nZS5sb2ctLTItMTgtMw==&channel=WEB | With Change | Before Change -- | -- | -- Total GC count | 33 | 47 Total reclaimed bytes | 44.28 gb | 66.43 gb Total GC time | 2 sec 405 ms | 3 sec 250 ms Avg GC time | 72.9 ms | 69.1 ms GC avg time std dev | 175 ms | 164 ms GC min/max time | 0.848 ms / 690 ms | 0.651 ms / 833 ms GC Interval avg time | 1 sec 154 ms | 911 ms Minor GC count | 31 | 44 Minor GC reclaimed | 43.95 gb | 66.14 gb Minor GC total time | 1 sec 96 ms | 1 sec 720 ms Minor GC avg time | 35.4 ms | 39.1 ms Minor GC avg time std dev | 96.6 ms | 97.5 ms Minor GC min/max time | 0.848 ms / 535 ms | 0.651 ms / 553 ms Minor GC Interval avg | 1 sec 231 ms | 975 ms Full GC Count | 2 | 3 Full GC reclaimed | 339.23 mb | 303.5 mb Full GC total time | 1 sec 309 ms | 1 sec 530 ms Full GC avg time | 654 ms | 510 ms Full GC avg time std dev | 35.1 ms | 269 ms Full GC min/max time | 619 ms / 690 ms | 174 ms / 833 ms Full GC Interval avg | 2 sec 392 ms | 6 sec 601 ms As the results show, there is clearly improvement in both the minor and major GCs, GC time and the memory used. Please take a look.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
