jackjlli commented on a change in pull request #4430: Cleanup un-necessary
setups in HelixSetupUtils
URL: https://github.com/apache/incubator-pinot/pull/4430#discussion_r303528725
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerStarter.java
##########
@@ -219,7 +221,7 @@ public void start() {
private void setUpHelixController() {
// Register and connect instance as Helix controller.
LOGGER.info("Starting Helix controller");
- _helixControllerManager = HelixSetupUtils.setup(_helixClusterName,
_helixZkURL, _instanceId);
+ _helixControllerManager =
HelixSetupUtils.setupHelixController(_helixClusterName, _helixZkURL,
_instanceId);
Review comment:
It's not just setting up the controller, it also creates the cluster if
needed as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
