Jackie-Jiang commented on a change in pull request #4418: Fix potential
resource leak in the way we close a collection of closeables
URL: https://github.com/apache/incubator-pinot/pull/4418#discussion_r303624815
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/io/writer/impl/FixedByteSingleValueMultiColWriter.java
##########
@@ -99,9 +100,12 @@ public void setBytes(int row, int col, byte[] bytes) {
indexDataBuffer.readFrom(offset, bytes);
}
+ @Override
public void close()
throws IOException {
- this.indexDataBuffer.close();
- this.indexDataBuffer = null;
+ if (this.indexDataBuffer != null) {
Review comment:
In case of multi-threading, final is safer than non-volatile variable. I
don't think we should throw NPE if the buffer is already closed, which could be
confusing, and not align with Closable's usual behavior. I prefer the final +
no null check way, @mcvsubbu what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
