mcvsubbu commented on a change in pull request #4368: 3891: Check for validity
of segment start/end time during segment generation
URL: https://github.com/apache/incubator-pinot/pull/4368#discussion_r303622987
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/realtime/converter/RealtimeSegmentConverter.java
##########
@@ -95,6 +95,7 @@ public void build(@Nullable SegmentVersion segmentVersion,
ServerMetrics serverM
reader = new RealtimeSegmentRecordReader(realtimeSegmentImpl,
dataSchema, sortedColumn);
}
SegmentGeneratorConfig genConfig = new SegmentGeneratorConfig(dataSchema);
+ genConfig.setCheckTimeColumnValidityDuringGeneration(false);
Review comment:
Good to add a comment here saying that we don't want realitme consumption to
stop (if the exception fires, consumption _will_ stop) in case application is
pushing bad data, so we explicitly ignore the time column check while
generating realtime segments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
